Update databastract
authorSteve Sutton <steve@gaslightmedia.com>
Fri, 11 Oct 2019 12:59:56 +0000 (08:59 -0400)
committerSteve Sutton <steve@gaslightmedia.com>
Fri, 11 Oct 2019 12:59:56 +0000 (08:59 -0400)
Don't use extract.
Initialize each one.

lib/GlmDataAbstract/DataAbstract.php

index f29f69d..6c0ae56 100755 (executable)
@@ -3300,8 +3300,17 @@ $forEdit = true;
         $params = array_merge( $defaults, $config );
         // echo '<pre>$params: ' . print_r( $params, true ) . '</pre>';
 
-        // extract $params Array
-        extract( $params );
+        // Initialize all parameters.
+        $where               = $params['where'];
+        $order               = $params['order'];
+        $fieldVals           = $params['fieldVals'];
+        $idField             = $params['idField'];
+        $start               = $params['start'];
+        $limit               = $params['limit'];
+        $prohibitListOptions = $params['prohibitListOptions'];
+        $appendSelect        = $params['appendSelect'];
+        $groupby             = $params['groupby'];
+        $stats               = $params['stats'];
 
         $this->selectGroupFields();