fixing js bug in the header search filter
authorAnthony Talarico <talarico@gaslightmedia.com>
Thu, 27 Apr 2017 14:06:25 +0000 (10:06 -0400)
committerAnthony Talarico <talarico@gaslightmedia.com>
Thu, 27 Apr 2017 14:06:25 +0000 (10:06 -0400)
needed to remove the default text in the select option for the destinations dropdown, otherwise
it wouldn't populate the activities list when resetting the options

js/app.js
js/custom/headerSearch.js

index c336853..fe74d93 100644 (file)
--- a/js/app.js
+++ b/js/app.js
@@ -98,7 +98,6 @@ $(document).ready(function () {
                 
                 $.each(region_data.counties, function(index, value){
                    var option = $('<option>', {value: index, text: value});
-                   option.attr('data-id', index);
                    counties.append(option);
                 });
             }
@@ -159,7 +158,7 @@ $(document).ready(function () {
                 });
                 option = {};
                 destinations.empty();
-                destinations.append($('<option>', {value: 'default', text: 'Select a Destination'}));
+                destinations.append($('<option>', {value: '', text: 'Select a Destination'}));
                 $.each(activity_data.categories.Destinations, function(index, value) {
                     var option = $('<option>', {value: value.category, text: value.name});
                     destinations.append(option);
@@ -282,8 +281,6 @@ $(document).ready(function () {
                 $.each(destination_data.categories.Activities, function(index, value) {
                     console.log(value);
                     var option = $('<option>', {value: value.category, text: value.name});
-                    option.attr('data-taxonomy', value.taxonomy);
-                    option.attr('data-id', value.id);
                     activities.append(option);
                 });
                 
@@ -293,8 +290,6 @@ $(document).ready(function () {
                 $.each(destination_data.categories.Parks, function(index, value) {
                     console.log(value);
                     var option = $('<option>', {value: value.category, text: value.name});
-                    option.attr('data-taxonomy', value.taxonomy);
-                    option.attr('data-id', value.id);
                     parks.append(option);
                 });
             }
index 9b5c243..2939ed9 100644 (file)
@@ -89,7 +89,6 @@ $(document).ready(function () {
                 
                 $.each(region_data.counties, function(index, value){
                    var option = $('<option>', {value: index, text: value});
-                   option.attr('data-id', index);
                    counties.append(option);
                 });
             }
@@ -150,7 +149,7 @@ $(document).ready(function () {
                 });
                 option = {};
                 destinations.empty();
-                destinations.append($('<option>', {value: 'default', text: 'Select a Destination'}));
+                destinations.append($('<option>', {value: '', text: 'Select a Destination'}));
                 $.each(activity_data.categories.Destinations, function(index, value) {
                     var option = $('<option>', {value: value.category, text: value.name});
                     destinations.append(option);
@@ -273,8 +272,6 @@ $(document).ready(function () {
                 $.each(destination_data.categories.Activities, function(index, value) {
                     console.log(value);
                     var option = $('<option>', {value: value.category, text: value.name});
-                    option.attr('data-taxonomy', value.taxonomy);
-                    option.attr('data-id', value.id);
                     activities.append(option);
                 });
                 
@@ -284,8 +281,6 @@ $(document).ready(function () {
                 $.each(destination_data.categories.Parks, function(index, value) {
                     console.log(value);
                     var option = $('<option>', {value: value.category, text: value.name});
-                    option.attr('data-taxonomy', value.taxonomy);
-                    option.attr('data-id', value.id);
                     parks.append(option);
                 });
             }