From: Steve Sutton <steve@gaslightmedia.com>
Date: Fri, 11 Oct 2019 12:59:56 +0000 (-0400)
Subject: Update databastract
X-Git-Url: http://cvs2.gaslightmedia.com/gitweb/?a=commitdiff_plain;h=5da1dc3cd078fead96cd5dc4a0364486bc51a753;p=WP-Plugins%2Fglm-member-db.git

Update databastract

Don't use extract.
Initialize each one.
---

diff --git a/lib/GlmDataAbstract/DataAbstract.php b/lib/GlmDataAbstract/DataAbstract.php
index f29f69d5..6c0ae569 100755
--- a/lib/GlmDataAbstract/DataAbstract.php
+++ b/lib/GlmDataAbstract/DataAbstract.php
@@ -3300,8 +3300,17 @@ $forEdit = true;
         $params = array_merge( $defaults, $config );
         // echo '<pre>$params: ' . print_r( $params, true ) . '</pre>';
 
-        // extract $params Array
-        extract( $params );
+        // Initialize all parameters.
+        $where               = $params['where'];
+        $order               = $params['order'];
+        $fieldVals           = $params['fieldVals'];
+        $idField             = $params['idField'];
+        $start               = $params['start'];
+        $limit               = $params['limit'];
+        $prohibitListOptions = $params['prohibitListOptions'];
+        $appendSelect        = $params['appendSelect'];
+        $groupby             = $params['groupby'];
+        $stats               = $params['stats'];
 
         $this->selectGroupFields();