From: Chuck Scott <cscott@gaslightmedia.com>
Date: Mon, 11 Jun 2018 15:15:25 +0000 (-0400)
Subject: Fixed various "Undefined Index" issues
X-Git-Tag: v1.0.1^2~3
X-Git-Url: http://cvs2.gaslightmedia.com/gitweb/?a=commitdiff_plain;h=83c32e9f6e55c5a243a47e6c5f39993c489749af;p=WP-Plugins%2Fglm-member-db-registrations.git

Fixed various "Undefined Index" issues

Fixed problem in dataRegEvent.php with post-processing of payment methods when those are not in use.
Removed "Time Specific" test messages from log in dataRegEvent.php.
Set missing default false for "selectedTime" parameter from view data in admin/registrations/events.php.
---

diff --git a/classes/data/dataRegEvent.php b/classes/data/dataRegEvent.php
index adc873c..62cc04b 100644
--- a/classes/data/dataRegEvent.php
+++ b/classes/data/dataRegEvent.php
@@ -352,12 +352,14 @@ class GlmDataRegistrationsRegEvent extends GlmDataAbstract
     public function entryPostProcessing( $result_data, $action )
     {
 
-        // Remove payment methods that are turned of in management
-        foreach ($result_data['payment_methods']['bitmap'] as $pmKey=>$pm) {
-            $bit = pow(2, $pm['value']);
-            if (($bit & $this->config['settings']['reg_payment_methods']) == 0) {
-                unset($result_data['payment_methods']['bitmap'][$pmKey]);
-                unset($result_data['restricted_payment_methods']['bitmap'][$pmKey]);
+        // If we have Payment Methods field data, Remove payment methods that are turned of in management
+        if (isset($result_data['payment_methods'])) {
+            foreach ($result_data['payment_methods']['bitmap'] as $pmKey=>$pm) {
+                $bit = pow(2, $pm['value']);
+                if (($bit & $this->config['settings']['reg_payment_methods']) == 0) {
+                    unset($result_data['payment_methods']['bitmap'][$pmKey]);
+                    unset($result_data['restricted_payment_methods']['bitmap'][$pmKey]);
+                }
             }
         }
 
@@ -441,7 +443,7 @@ class GlmDataRegistrationsRegEvent extends GlmDataAbstract
     {
 
         if ($time_specific['value']) {
-trigger_error("**** Time SPecific",E_USER_NOTICE);
+
             $sql = "
                 SELECT SUM(attendee_max) AS total, SUM(attendee_count) AS registered, SUM(attendees_pending) AS cartHold, SUM(attendees_available) AS curAvail
                   FROM ".GLM_MEMBERS_REGISTRATIONS_PLUGIN_DB_PREFIX."reg_time
@@ -450,7 +452,7 @@ trigger_error("**** Time SPecific",E_USER_NOTICE);
                    AND non_time_specific = false
             ";
         } else {
-trigger_error("**** Not Time SPecific",E_USER_NOTICE);
+
             $sql = "
                 SELECT SUM(attendee_max) AS total, SUM(attendee_count) AS registered, SUM(attendees_pending) AS cartHold, SUM(attendees_available) AS curAvail
                   FROM ".GLM_MEMBERS_REGISTRATIONS_PLUGIN_DB_PREFIX."reg_time
diff --git a/models/admin/registrations/events.php b/models/admin/registrations/events.php
index c39648f..eeb7bef 100644
--- a/models/admin/registrations/events.php
+++ b/models/admin/registrations/events.php
@@ -131,6 +131,7 @@ class GlmMembersAdmin_registrations_events extends GlmDataRegistrationsRegEvent
         $when                      = false;
         $haveTimes                 = false;
         $times                     = false;
+        $selectedTime              = false;
         $notifications             = '';
 
         // Register the masked input script that we need for input controls
diff --git a/views/admin/registrations/eventEdit.html b/views/admin/registrations/eventEdit.html
index 85c3b28..b13fbaa 100644
--- a/views/admin/registrations/eventEdit.html
+++ b/views/admin/registrations/eventEdit.html
@@ -88,18 +88,6 @@
                 {if $regEvent.fieldFail.reg_hold_minutes}<p>{$regEvent.fieldFail.reg_hold_minutes}</p>{/if}<br>
                 </td>
             </tr>
-<!-- No longer in use, now using defined parameter for all hold days for all requests
-            <tr>
-                <th {if $regEvent.fieldRequired.cart_hold_days}class="glm-required-nowrap-left-align"{else}class="glm-nowrap-left-align"{/if}>Cart Hold (days):</th>
-                <td {if $regEvent.fieldFail.cart_hold_days}class="glm-form-bad-input" data-tabid="glm-cart_hold_days"{/if}>
-                    If the user has {$terms.reg_term_registration_plur} entered but has not yet checked out, their "cart" will be maintained for this number of days.
-                    After that time, the card will be deleted. If a user has established a {$terms.reg_term_registration_plur} account (entered {$terms.reg_term_registration_plur} or
-                    have been {$terms.reg_term_registered} before, the user will be able log in and continue with the cart up to this number of days.<br>
-                    <input type="text" name="cart_hold_days" value="{$regEvent.fieldData.cart_hold_days}" class="glm-form-text-input-medium">
-                {if $regEvent.fieldFail.cart_hold_days}<p>{$regEvent.fieldFail.cart_hold_days}</p>{/if}<br>
-                </td>
-            </tr>
--->            
             <tr>
                 <th {if $regEvent.fieldRequired.reg_hours_before}class="glm-required-nowrap-left-align"{else}class="glm-nowrap-left-align"{/if}>End of {$terms.reg_term_registration_cap}:</th>
                 <td {if $regEvent.fieldFail.reg_hours_before}class="glm-form-bad-input" data-tabid="glm-reg_hours_before"{/if}>