From: Steve Sutton <steve@gaslightmedia.com>
Date: Fri, 7 Dec 2018 15:39:42 +0000 (-0500)
Subject: Check for an array for messages
X-Git-Tag: v2.2.0^2~4
X-Git-Url: http://cvs2.gaslightmedia.com/gitweb/?a=commitdiff_plain;h=f3b2db56f6a4c361a2b3fc4c93534435175d291a;p=WP-Plugins%2Fglm-serverstats.git

Check for an array for messages

Check for a non empty array before using foreach on messages.
---

diff --git a/setup/adminHooks.php b/setup/adminHooks.php
index 7e2f826..aab7534 100644
--- a/setup/adminHooks.php
+++ b/setup/adminHooks.php
@@ -103,12 +103,13 @@ if ( $user_is_admin || $user_is_editor ) {
                 // If we get a good response.
                 if ( $status == 200 ) {
                     $messages = json_decode( $message_data, true );
-                    // trigger_error( '$messages: ' . print_r( $messages, true ), E_USER_NOTICE );
-                    foreach ( $messages as $message ) {
-                        $title             = $message['title'];
-                        $dashboard_message = $message['dashboard_message'];
-                        $id                = $message['id'];
-                        $updated           = $message['updated']['timestamp'];
+                    if ( is_array( $messages ) && !empty( $messages ) ) {
+                        foreach ( $messages as $message ) {
+                            $title             = $message['title'];
+                            $dashboard_message = $message['dashboard_message'];
+                            $id                = $message['id'];
+                            $updated           = $message['updated']['timestamp'];
+                        }
                     }
                 } else {
                     // Don't do anything here yet.