From 383303e4607d4201a14d9c1c3de0aa206647dbba Mon Sep 17 00:00:00 2001
From: Laury GvR <laury@gaslightmedia.com>
Date: Fri, 3 Aug 2018 15:43:21 -0400
Subject: [PATCH] various fixes after the meeting (see notes for details)

- Addressee name title field
- Addressee placeholder added
- Mailing Address Type placeholder added
- Field labels now have 16px font, sections 18px
- If empty last updated field: don't show empty field
- Remove extra container around entire form
- Noinput font color changed
- Management/access to members listing restyled
---
 css/admin.css                  | 30 ++++++++++++++++++------------
 views/admin/contacts/edit.html | 14 ++++++++------
 views/front/contacts/list.html |  2 +-
 3 files changed, 27 insertions(+), 19 deletions(-)

diff --git a/css/admin.css b/css/admin.css
index 9440f04..019736c 100644
--- a/css/admin.css
+++ b/css/admin.css
@@ -3,7 +3,8 @@
     max-width: 100%;
 }
 #glm-admin-contact-wrapper #glm-admin-content-container  {
-    background: #f8f8fb;
+    background: transparent;
+    border: 0;
     max-width: 1000px;
 }
 @media only screen and (max-width: 639px) {
@@ -52,7 +53,7 @@
 }
 #glm-admin-content-container .glm-contact-content-toggle h3 {
     color: #32373c;
-    font-size: 13px;
+    font-size: 18px;
     line-height: 1.6;
     margin-bottom: 2px;
     margin-top: 2px;
@@ -183,10 +184,10 @@ input::placeholder {
         max-width: 100%;
     }
 }
-#glm-table-profile.glm-admin-table td > .glm-admin-noinput {
+#glm-table-profile.glm-admin-table td .glm-admin-noinput {
     background: #f3f3f9;
     border: 1px solid #e1e1e1;
-    color: #575757;
+    color: #919191;
     font-size: 15px;
     display: inline-block;
     margin: 1px;
@@ -247,14 +248,6 @@ input::placeholder {
 #glm-table-profile .glm-item-container {
     float: left;
 }
-
-#glm-table-profile.glm-admin-table th {
-    color: #515151;
-    font-size: 13px;
-    padding-bottom: 14px;
-    padding-top: 14px;
-    line-height: 1.6px;
-}
 #glm-table-profile input[type=text] {
     font-size: 15px;
 }
@@ -274,6 +267,11 @@ input::placeholder {
     max-width: 100%;
     padding-bottom: 7px;
     width: 100%;
+    color: #515151;
+    font-size: 15px;
+    padding-bottom: 14px;
+    padding-top: 14px;
+    line-height: 1.6px;
 }
 #glm-table-profile.glm-admin-table tr {
     display: block;
@@ -418,6 +416,14 @@ display: inline-block;
     display: block;
     float: left;
     clear: both;
+    color: #919191;
+    border-radius: 0;
+    background: #f3f3f3;
+    border: 1px solid #e1e1e1;
+    font-size: 15px;
+    padding: 4px 8px;
+    margin: 1px;
+    min-width: 200px;
 }
 #glm-table-profile .glm-contacts-checkbox{
     float: left;
diff --git a/views/admin/contacts/edit.html b/views/admin/contacts/edit.html
index 0c212e7..d07fe7f 100644
--- a/views/admin/contacts/edit.html
+++ b/views/admin/contacts/edit.html
@@ -191,10 +191,12 @@
                                     <th>Created</th>
                                     <td><span class="glm-admin-noinput">{$contactInfo.fieldData.create_time.datetime}</span></td>
                                 </tr>
+                                {if $contactInfo.fieldData.modify_time.datetime}
                                 <tr>
                                     <th>Last Updated</th>
                                     <td><span class="glm-admin-noinput">{$contactInfo.fieldData.modify_time.datetime}</span></td>
                                 </tr>
+                                {/if}
                             {/if}
                         </table>
                         <div class="glm-contact-sub-data-links glmgrid-row">
@@ -391,7 +393,7 @@
                             </tr>
                             <tr>
                                 <th>Management/Access to</th>
-                                <td id="accessToMemberSelection" class="glm-item-container">
+                                <td id="accessToMemberSelection">
                             {if $membersList && apply_filters('glm_members_menu_members',true)}
                                     <!-- Other Member Selection -->
                                     <select name="memberSelect" id="memberSelect">
@@ -407,7 +409,7 @@
                                     <div id="selectedMembers" class="glm-dynSelect-box">
                                 {if $contactMembers}
                                 {foreach $contactMembers as $m}
-                                        <div data-id="{$m.id}" class="glm-dynSelect-item glm-members-members">
+                                        <div data-id="{$m.id}" class="glm-dynSelect-item glm-members-members glm-admin-noinput">
                                             {$m.name}
                                     {if $m.id != $memberID}
                                             <span data-id="{$m.id}" class="glm-dynSelect-delete membDelete">X</span>
@@ -423,7 +425,7 @@
                                 {if $contactMembers}
                                         <input type="hidden" name="contactMembers[0]" value="0"> <!-- flag to not update contact members list -->
                                     {foreach $contactMembers as $m}
-                                        <div data-id="{$m.id}" class="glm-dynSelect-item">
+                                        <div data-id="{$m.id}" class="glm-dynSelect-item glm-admin-noinput">
                                             {$m.name}
                                         </div>
                                     {/foreach}
@@ -472,14 +474,14 @@
                             <tr>
                                 <th {if $contactInfo.fieldRequired.mailing_address_type}class="glm-required"{/if}>Mailing Address Type</th>
                                 <td {if $contactInfo.fieldFail.mailing_address_type}class="glm-form-bad-input"{/if}>
-                                    <input type="text" id="mailing_address_type" name="mailing_address_type" value="{$contactInfo.fieldData.mailing_address_type}" class="glm-form-text-input-short">
+                                    <input type="text" id="mailing_address_type" name="mailing_address_type" placeholder="(e.g. Winter/Summer Address)" value="{$contactInfo.fieldData.mailing_address_type}" class="glm-form-text-input-short">
                                     {if $contactInfo.fieldFail.mailing_address_type}<p>{$contactInfo.fieldFail.mailing_address_type}</p>{/if}
                                 </td>
                             </tr>
                             <tr>
-                                <th {if $contactInfo.fieldRequired.mailto_label}class="glm-required"{/if}>'Mail To' Label</th>
+                                <th {if $contactInfo.fieldRequired.mailto_label}class="glm-required"{/if}>Addressee Name</th>
                                 <td {if $contactInfo.fieldFail.mailto_label}class="glm-form-bad-input"{/if}>
-                                    <input type="text" id="mailto_label" name="mailto_label" value="{$contactInfo.fieldData.mailto_label}" class="glm-form-text-input-short">
+                                    <input type="text" id="mailto_label" name="mailto_label" value="{$contactInfo.fieldData.mailto_label}" placeholder="(e.g. Mr. John Doe)" class="glm-form-text-input-short">
                                     {if $contactInfo.fieldFail.mailto_label}<p>{$contactInfo.fieldFail.mailto_label}</p>{/if}
                                 </td>
                             </tr>
diff --git a/views/front/contacts/list.html b/views/front/contacts/list.html
index a024a43..951498e 100644
--- a/views/front/contacts/list.html
+++ b/views/front/contacts/list.html
@@ -173,7 +173,7 @@ and open the template in the editor.
                         <div class="section-data">
                             <div class="section-field">
                                 <span class="field-title">
-                                    Contact For
+                                    Mailing Address Type
                                 </span>
                                 <span class="field-value">
                                     {if $contact.ref_type.name}{$contact.ref_type.name}{/if}
-- 
2.17.1