From 53b7fd049b5fd7972a0c646977a0bab0c1f36bca Mon Sep 17 00:00:00 2001
From: Laury GvR <laury@gaslightmedia.com>
Date: Tue, 13 Mar 2018 16:45:08 -0400
Subject: [PATCH] Better alternative to check for member type Simple

The previous method would set the setting to false for all members
resulting in all the links to malfunction. Instead the member type
is checked at every instance of where list_show_detail_link is
checked, which is more work/code but a lot more reliable.
---
 glm-member-db/views/front/members/list.html | 13 +++++++------
 1 file changed, 7 insertions(+), 6 deletions(-)

diff --git a/glm-member-db/views/front/members/list.html b/glm-member-db/views/front/members/list.html
index e0457fb..12f2d63 100644
--- a/glm-member-db/views/front/members/list.html
+++ b/glm-member-db/views/front/members/list.html
@@ -220,12 +220,14 @@
     {if $view == grid}
         <ul class="small-block-grid-1 medium-block-grid-2 large-block-grid-3">
         {foreach $members as $member}
+            {$member_type = apply_filters('glma_get_member_type', $member.id)}
+            {if !$member_type}{$member_type = "Default"}{/if}
             <li class="glm-member-list-record">
                 {apply_filters('glm-member-db-front-members-list-memberAbove', '', $member.member_pointer)}
                 <div class="glm-member-db-border-wrap">
                     {apply_filters('glm-member-db-front-members-list-memberTop', '', $member.member_pointer)}
 
-                    {if $settings.list_show_detail_link}
+                    {if $settings.list_show_detail_link && "Simple" !== $member_type}
                     <a class="glm-member-list-image-wrapper" href="{$siteBaseUrl}{$settings.canonical_member_page}/{$member.member_slug}/">
                     {/if}
 
@@ -246,12 +248,12 @@
                     {else}
                         <div class="glm-member-list-missing-image"></div>
                     {/if}
-                    {if $settings.list_show_detail_link}
+                    {if $settings.list_show_detail_link && "Simple" !== $member_type}
                     </a>
                     {/if}
                     <div class="glm-member-list-info-wrapper">
                         <h4 class="glm-member-title">
-                            {if $settings.list_show_detail_link}
+                            {if $settings.list_show_detail_link && "Simple" !== $member_type}
                                 <a href="{$siteBaseUrl}{$settings.canonical_member_page}/{$member.member_slug}/{if $settings.enable_multiple_profiles}{$member.id}/{/if}">
                                     {$member.member}
                                 </a>
@@ -295,7 +297,6 @@
         
         {$member_type = apply_filters('glma_get_member_type', $member.id)}
         {if !$member_type}{$member_type = "Default"}{/if}
-        {if "Simple" == $member_type}{$settings.list_show_detail_link = false}{/if}
         
         {apply_filters('glm-member-db-front-members-list-memberAbove', '', $member.member_pointer)}
              <div class="glm-member-list-container glm-member-container small-12 columns">
@@ -322,7 +323,7 @@
  <!-- Member name, address, and basic information -->
                     {apply_filters('glm-member-db-front-members-list-memberInfoTop', '', $member.member_pointer)}
                     <h4 class="glm-member-title">
-                        {if $settings.list_show_detail_link}
+                        {if $settings.list_show_detail_link && "Simple" !== $member_type}
                             <a class="glm-member-title-inner" href="{$siteBaseUrl}{$settings.canonical_member_page}/{$member.member_slug}/{if $settings.enable_multiple_profiles}{$member.id}/{/if}">{$member.member}</a>
                         {else}
                             <span class="glm-member-title-inner">{$member.member}</span>
@@ -386,7 +387,7 @@
                     {apply_filters('glm-member-db-front-members-list-memberDescriptionTop', '', $member.member_pointer)}
                     {if $member.short_descr && $settings.list_show_short_descr}
                         {$member.short_descr|nl2br}
-                        {if $settings.list_show_detail_link}
+                        {if $settings.list_show_detail_link && "Simple" !== $member_type}
                             <a href="{$siteBaseUrl}{$settings.canonical_member_page}/{$member.member_slug}/{if $settings.enable_multiple_profiles}{$member.id}/{/if}">More</a>
                         {/if}
                     {/if}
-- 
2.17.1