From bf86d7a2a251cdad0d554f2cc42d386c70519626 Mon Sep 17 00:00:00 2001
From: Anthony Talarico <talarico@gaslightmedia.com>
Date: Thu, 27 Apr 2017 10:06:25 -0400
Subject: [PATCH] fixing js bug in the header search filter

needed to remove the default text in the select option for the destinations dropdown, otherwise
it wouldn't populate the activities list when resetting the options
---
 js/app.js                 | 7 +------
 js/custom/headerSearch.js | 7 +------
 2 files changed, 2 insertions(+), 12 deletions(-)

diff --git a/js/app.js b/js/app.js
index c336853..fe74d93 100644
--- a/js/app.js
+++ b/js/app.js
@@ -98,7 +98,6 @@ $(document).ready(function () {
                 
                 $.each(region_data.counties, function(index, value){
                    var option = $('<option>', {value: index, text: value});
-                   option.attr('data-id', index);
                    counties.append(option);
                 });
             }
@@ -159,7 +158,7 @@ $(document).ready(function () {
                 });
                 option = {};
                 destinations.empty();
-                destinations.append($('<option>', {value: 'default', text: 'Select a Destination'}));
+                destinations.append($('<option>', {value: '', text: 'Select a Destination'}));
                 $.each(activity_data.categories.Destinations, function(index, value) {
                     var option = $('<option>', {value: value.category, text: value.name});
                     destinations.append(option);
@@ -282,8 +281,6 @@ $(document).ready(function () {
                 $.each(destination_data.categories.Activities, function(index, value) {
                     console.log(value);
                     var option = $('<option>', {value: value.category, text: value.name});
-                    option.attr('data-taxonomy', value.taxonomy);
-                    option.attr('data-id', value.id);
                     activities.append(option);
                 });
                 
@@ -293,8 +290,6 @@ $(document).ready(function () {
                 $.each(destination_data.categories.Parks, function(index, value) {
                     console.log(value);
                     var option = $('<option>', {value: value.category, text: value.name});
-                    option.attr('data-taxonomy', value.taxonomy);
-                    option.attr('data-id', value.id);
                     parks.append(option);
                 });
             }
diff --git a/js/custom/headerSearch.js b/js/custom/headerSearch.js
index 9b5c243..2939ed9 100644
--- a/js/custom/headerSearch.js
+++ b/js/custom/headerSearch.js
@@ -89,7 +89,6 @@ $(document).ready(function () {
                 
                 $.each(region_data.counties, function(index, value){
                    var option = $('<option>', {value: index, text: value});
-                   option.attr('data-id', index);
                    counties.append(option);
                 });
             }
@@ -150,7 +149,7 @@ $(document).ready(function () {
                 });
                 option = {};
                 destinations.empty();
-                destinations.append($('<option>', {value: 'default', text: 'Select a Destination'}));
+                destinations.append($('<option>', {value: '', text: 'Select a Destination'}));
                 $.each(activity_data.categories.Destinations, function(index, value) {
                     var option = $('<option>', {value: value.category, text: value.name});
                     destinations.append(option);
@@ -273,8 +272,6 @@ $(document).ready(function () {
                 $.each(destination_data.categories.Activities, function(index, value) {
                     console.log(value);
                     var option = $('<option>', {value: value.category, text: value.name});
-                    option.attr('data-taxonomy', value.taxonomy);
-                    option.attr('data-id', value.id);
                     activities.append(option);
                 });
                 
@@ -284,8 +281,6 @@ $(document).ready(function () {
                 $.each(destination_data.categories.Parks, function(index, value) {
                     console.log(value);
                     var option = $('<option>', {value: value.category, text: value.name});
-                    option.attr('data-taxonomy', value.taxonomy);
-                    option.attr('data-id', value.id);
                     parks.append(option);
                 });
             }
-- 
2.17.1